Fix obsolete wheel usage in addtag #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 87.19% 88.21% +1.02%
==========================================
Files 19 19
Lines 976 976
Branches 214 214
==========================================
+ Hits 851 861 +10
+ Misses 86 74 -12
- Partials 39 41 +2
Continue to review full report at Codecov.
|
lkollar
changed the title
lkollar
force-pushed
the
fix-wheel
branch
2 times, most recently
from
6b21040
to
cded397
Compare
We upgraded to wheel 0.34.1 and the API is slightly different. The addtag command was not updated for the change.
lkollar
changed the title
|
The s390x build is still failing due to #228 and it's unclear when Travis will fix this. Meanwhile the addtag command is broken so I think it's best if we land this without the s390x build. |
|
Looks like it's actually failing due to pypa/manylinux#473. Agreed that this can land w/o the s309x build passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgraded to wheel 0.34.1 and the API is slightly different. The
addtag command was not updated for the change.
The included test fails without the fix.